Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: simplify heap space iteration #26285

Merged
merged 1 commit into from
Feb 27, 2019
Merged

report: simplify heap space iteration #26285

merged 1 commit into from
Feb 27, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 24, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 24, 2019
@cjihrig
report: simplify heap space iteration
084f74a 
PR-URL: nodejs#26285
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 27, 2019

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/21011/

@cjihrig cjihrig merged commit 084f74a into nodejs:master Feb 27, 2019
@cjihrig cjihrig deleted the loop branch February 27, 2019 00:55
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@cjihrig @addaleax
report: simplify heap space iteration
d2d9453 
PR-URL: #26285
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @richardlau